[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 8/9] intel_iommu: fix VTD_SID_TO_BUS
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 8/9] intel_iommu: fix VTD_SID_TO_BUS |
Date: |
Wed, 22 Oct 2014 11:18:31 +0300 |
(((sid) >> 8) && 0xff) makes no sense
(((sid) >> 8) & 0xff) seems to be what was meant.
https://bugs.launchpad.net/qemu/+bug/1382477
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/i386/intel_iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index f4701e1..e321ee4 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -37,7 +37,7 @@
#define VTD_PCI_DEVFN_MAX 256
#define VTD_PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f)
#define VTD_PCI_FUNC(devfn) ((devfn) & 0x07)
-#define VTD_SID_TO_BUS(sid) (((sid) >> 8) && 0xff)
+#define VTD_SID_TO_BUS(sid) (((sid) >> 8) & 0xff)
#define VTD_SID_TO_DEVFN(sid) ((sid) & 0xff)
#define DMAR_REG_SIZE 0x230
--
MST
- [Qemu-devel] [PULL v2 0/9] pc, virtio, misc bugfixes, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 1/9] smbios: Fix assertion on socket count calculation, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 2/9] well-defined listing order for machine types, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 3/9] i386/pc: add piix and q35 machtypes to sorting families for -M \?, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 4/9] pc: Fix disabling of vapic for compat PC models, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 5/9] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive., Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 6/9] pcie: change confused comment clearer, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 7/9] virtio-pci: fix migration for pci bus master, Michael S. Tsirkin, 2014/10/22
- [Qemu-devel] [PULL v2 8/9] intel_iommu: fix VTD_SID_TO_BUS,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v2 9/9] tests: fix rebuild-expected-aml.sh for acpi-test rename, Michael S. Tsirkin, 2014/10/22
- Re: [Qemu-devel] [PULL v2 0/9] pc, virtio, misc bugfixes, Peter Maydell, 2014/10/22