[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 03/17] qcow2: Fix leaks in dirty images
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v8 03/17] qcow2: Fix leaks in dirty images |
Date: |
Wed, 22 Oct 2014 14:09:29 +0200 |
When opening dirty images, qcow2's repair function should not only
repair errors but leaks as well.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: BenoƮt Canet <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 3c8b881..7a2c66f 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -910,7 +910,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options,
int flags,
(s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) {
BdrvCheckResult result = {0};
- ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS);
+ ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAKS);
if (ret < 0) {
error_setg_errno(errp, -ret, "Could not repair dirty image");
goto fail;
--
1.9.3
- [Qemu-devel] [PATCH v8 00/17] qcow2: Fix image repairing, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 02/17] qcow2: Calculate refcount block entry count, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 04/17] qcow2: Split qcow2_check_refcounts(), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 01/17] block: Add qemu_{, try_}blockalign0(), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 06/17] qcow2: Pull check_refblocks() up, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 03/17] qcow2: Fix leaks in dirty images,
Max Reitz <=
- [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 07/17] qcow2: Use int64_t for in-memory reftable size, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 08/17] qcow2: Split fail code in L1 and L2 checks, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 09/17] qcow2: Let inc_refcounts() return -errno, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 11/17] qcow2: Reuse refcount table in calculate_refcounts(), Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 10/17] qcow2: Let inc_refcounts() resize the reftable, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 12/17] qcow2: Fix refcount blocks beyond image end, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 14/17] qcow2: Rebuild refcount structure during check, Max Reitz, 2014/10/22
- [Qemu-devel] [PATCH v8 13/17] qcow2: Do not perform potentially damaging repairs, Max Reitz, 2014/10/22