[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close()
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close() |
Date: |
Thu, 23 Oct 2014 15:40:30 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2014/10/23 15:09, Michael Tokarev wrote:
> On 10/23/2014 09:39 AM, address@hidden wrote:
>> From: Gonglei <address@hidden>
>>
>> vnc_display_close() is called in vnc_display_open().
>> And in this moment, the ds variable is initilized
>> at vnc_display_init(). Calling vnc_display_close()
>> is superfluous.
>
> Maybe the intent was to be able to open/close new vnc
> displays in the future? I think I've seen patches to
> allow several vnc displays at once...
>
I also saw Gerd's patch series for multiple vnc server instances.
But every vnc server has its own vnc status, they shouldn't
influence with each other. :) This logic is the same, initialize and
close immediately (the close process is superfluous).
Best regards,
-Gonglei