[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 47/47] End of migration for postcopy
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v4 47/47] End of migration for postcopy |
Date: |
Thu, 23 Oct 2014 15:24:13 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Paolo Bonzini (address@hidden) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > + mis->postcopy_ram_state);
> > + if (mis->postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) {
> > + /*
> > + * Where a migration had postcopy enabled (and thus went to advise)
> > + * but managed to complete within the precopy period
> > + */
> > + postcopy_ram_incoming_cleanup(mis);
> > + } else {
> > + if ((ret >= 0) &&
> > + (mis->postcopy_ram_state > POSTCOPY_RAM_INCOMING_ADVISE)) {
> > + /*
> > + * Postcopy was started, cleanup should happen at the end of
> > the
> > + * postcopy thread.
> > + */
> > + DPRINTF("process_incoming_migration_co: exiting main branch");
> > + return;
> > + }
>
> Extra parentheses and extra nesting.
Done.
>
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v4 41/47] qemu_ram_block_from_host, (continued)
- [Qemu-devel] [PATCH v4 41/47] qemu_ram_block_from_host, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 42/47] Don't sync dirty bitmaps in postcopy, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 44/47] Postcopy; Handle userfault requests, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 45/47] Start up a postcopy/listener thread ready for incoming page data, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 46/47] postcopy: Wire up loadvm_postcopy_ram_handle_{run, end} commands, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 47/47] End of migration for postcopy, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 34/47] Postcopy: Create a fault handler thread before marking the ram as userfault, Dr. David Alan Gilbert (git), 2014/10/03
- [Qemu-devel] [PATCH v4 39/47] postcopy_ram.c: place_page and helpers, Dr. David Alan Gilbert (git), 2014/10/03
- Re: [Qemu-devel] [PATCH v4 00/47] Postcopy implementation, Dr. David Alan Gilbert, 2014/10/03