[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] virtio-balloon: Tweak recent fix for integer ove
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 1/7] virtio-balloon: Tweak recent fix for integer overflow |
Date: |
Thu, 23 Oct 2014 11:19:44 -0400 |
From: Markus Armbruster <address@hidden>
Commit 1f9296b avoids "other kinds of overflow" by limiting the
polling interval to UINT_MAX. The computations to protect are done in
64 bits. This is indeed safe when unsigned is 32 bits, as it commonly
is. It isn't when unsigned is 64 bits. Purely theoretical; I'm not
aware of such a system. Limit it to UINT32_MAX instead.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
hw/virtio/virtio-balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index b5cf7ca..7bfbb75 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -170,7 +170,7 @@ static void balloon_stats_set_poll_interval(Object *obj,
struct Visitor *v,
return;
}
- if (value > UINT_MAX) {
+ if (value > UINT32_MAX) {
error_setg(errp, "timer value is too big");
return;
}
--
1.9.3
- [Qemu-devel] [PULL 0/7] QMP queue, Luiz Capitulino, 2014/10/23
- [Qemu-devel] [PULL 1/7] virtio-balloon: Tweak recent fix for integer overflow,
Luiz Capitulino <=
- [Qemu-devel] [PULL 2/7] dump: Propagate errors into qmp_dump_guest_memory(), Luiz Capitulino, 2014/10/23
- [Qemu-devel] [PULL 4/7] MAINTAINERS: add entry for qobject files, Luiz Capitulino, 2014/10/23
- [Qemu-devel] [PULL 5/7] qdev: add qdev_build_hotpluggable_device_list helper, Luiz Capitulino, 2014/10/23
- [Qemu-devel] [PULL 6/7] monitor: add del completion for peripheral device, Luiz Capitulino, 2014/10/23
- [Qemu-devel] [PULL 3/7] dump: Turn some functions to void to make code cleaner, Luiz Capitulino, 2014/10/23
- [Qemu-devel] [PULL 7/7] monitor: delete device_del_bus_completion, Luiz Capitulino, 2014/10/23
- Re: [Qemu-devel] [PULL 0/7] QMP queue, Peter Maydell, 2014/10/23