[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP |
Date: |
Fri, 24 Oct 2014 10:08:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/24/2014 07:57 AM, Max Reitz wrote:
> qemu-img should use QMP commands whenever possible in order to ensure
> feature completeness of both online and offline image operations. As
> qemu-img itself has no access to QMP (since this would basically require
> just everything being linked into qemu-img), imitate QMP's
> implementation of block-commit by using commit_active_start() and then
> waiting for the block job to finish.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/Makefile.objs | 3 +--
> qemu-img.c | 78
> ++++++++++++++++++++++++++++++++++++++++-------------
> 2 files changed, 60 insertions(+), 21 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v14 01/14] qcow2: Allow "full" discard, (continued)
- [Qemu-devel] [PATCH v14 01/14] qcow2: Allow "full" discard, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 03/14] qcow2: Optimize bdrv_make_empty(), Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 02/14] qcow2: Implement bdrv_make_empty(), Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 04/14] blockjob: Introduce block_job_complete_sync(), Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 06/14] iotests: Omit length/offset test in 040 and 041, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 05/14] blockjob: Add "ready" field, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 07/14] block/mirror: Improve progress report, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP, Max Reitz, 2014/10/24
- Re: [Qemu-devel] [PATCH v14 08/14] qemu-img: Implement commit like QMP,
Eric Blake <=
- [Qemu-devel] [PATCH v14 09/14] qemu-img: Empty image after commit, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 10/14] qemu-img: Enable progress output for commit, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 11/14] qemu-img: Specify backing file for commit, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 13/14] iotests: Add test for backing-chain commits, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 12/14] iotests: Add _filter_qemu_img_map, Max Reitz, 2014/10/24
- [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty, Max Reitz, 2014/10/24