[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests |
Date: |
Mon, 27 Oct 2014 10:18:48 +0100 |
Cancel oversized requests early. They would generate
an iSCSI protocol error anyway; after having transferred
possibly a lot of data over the wire.
Suggested-By: Max Reitz <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
---
block/iscsi.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index a4ba33b..111065d 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -362,6 +362,12 @@ static int coroutine_fn iscsi_co_writev(BlockDriverState
*bs,
return -EINVAL;
}
+ if (bs->bl.max_transfer_length && nb_sectors > bs->bl.max_transfer_length)
{
+ error_report("iSCSI Error: Write of %d sectors exceeds max_xfer_len "
+ "of %d sectors", nb_sectors, bs->bl.max_transfer_length);
+ return -EINVAL;
+ }
+
lba = sector_qemu2lun(sector_num, iscsilun);
num_sectors = sector_qemu2lun(nb_sectors, iscsilun);
iscsi_co_init_iscsitask(iscsilun, &iTask);
@@ -529,6 +535,12 @@ static int coroutine_fn iscsi_co_readv(BlockDriverState
*bs,
return -EINVAL;
}
+ if (bs->bl.max_transfer_length && nb_sectors > bs->bl.max_transfer_length)
{
+ error_report("iSCSI Error: Read of %d sectors exceeds max_xfer_len "
+ "of %d sectors", nb_sectors, bs->bl.max_transfer_length);
+ return -EINVAL;
+ }
+
if (iscsilun->lbprz && nb_sectors >= ISCSI_CHECKALLOC_THRES &&
!iscsi_allocationmap_is_allocated(iscsilun, sector_num, nb_sectors)) {
int64_t ret;
--
1.7.9.5
- [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 2/6] BlockLimits: introduce max_transfer_length, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 1/6] util: introduce MIN_NON_ZERO, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 4/6] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests,
Peter Lieven <=
- [Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits, Peter Lieven, 2014/10/27
- Re: [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length, Stefan Hajnoczi, 2014/10/28