[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev

From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable
Date: Mon, 27 Oct 2014 12:45:59 +0100


On Mon, Oct 27, 2014 at 9:08 AM, Gerd Hoffmann <address@hidden> wrote:
> +static void spice_chr_accept_input(struct CharDriverState *chr)
> +{
> +    SpiceCharDriver *s = chr->opaque;
> +
> +    spice_server_char_device_wakeup(&s->sin);

Does this build on older spice versions?  I'd suspect this needs #if

There is already a spice_server_char_device_wakeup() call there. On older servers, this additional call will trigger just a read try. With the proposed patch in Spice server, it will do read & write try (I didn't see the need to create a new function to do only read or write, both should be fine)

Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]