Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

[Marcel Apfelbaum]

On Mon, 2014-10-27 at 11:10 -0600, Eric Blake wrote:
> On 10/27/2014 10:41 AM, Marcel Apfelbaum wrote:
> > Hot-plugging a device that has a romfile (either supplied by user
> > or built-in) using rombar=0 option is an user error,
> 
> s/an/a/ (user is pronounced with a leading hard "y" sound rather than a
> soft "u", it may help to remember you can "give a unicorn an umbrella")
Thanks, still hard to get it right, but your tip will surely help :)

Michael, do you want me to send another version,
or you can change it on the fly?

Thanks,
Marcel

> 
> > do not allow the device to be hot-plugged.
> > 
> > Signed-off-by: Marcel Apfelbaum <address@hidden>
> > ---
> >  hw/pci/pci.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> 
> Reviewed-by: Eric Blake <address@hidden>
>