Re: [Qemu-devel] [PATCH 01/17] ahci: Fix CD-ROM signature

[Markus Armbruster]

Copying John Snow for additional AHCI expertise.

Hannes Reinecke <address@hidden> writes:

> The CD-ROM signature is 0xeb140101, not 0xeb140000.
> Without this change OVMF/Duet runs into a timeout trying
> to detect a SATA cdrom.
>
> Signed-off-by: Hannes Reinecke <address@hidden>
> ---
>  hw/ide/ahci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
> index e223258..970eea8 100644
> --- a/hw/ide/ahci.h
> +++ b/hw/ide/ahci.h
> @@ -161,7 +161,7 @@
>  #define AHCI_CMD_HDR_CMD_FIS_LEN           0x1f
>  #define AHCI_CMD_HDR_PRDT_LEN              16
>  
> -#define SATA_SIGNATURE_CDROM               0xeb140000
> +#define SATA_SIGNATURE_CDROM               0xeb140101
>  #define SATA_SIGNATURE_DISK                0x00000101
>  
>  #define AHCI_GENERIC_HOST_CONTROL_REGS_MAX_ADDR 0x20