|
From: | Leon Alrae |
Subject: | Re: [Qemu-devel] [PATCH v2 12/20] target-mips: add MSA BIT format instructions |
Date: | Thu, 30 Oct 2014 08:02:25 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 |
On 29/10/14 01:42, Yongbok Kim wrote: > + uint8_t wd = (ctx->opcode >> 6) & 0x1f; > + > + if ((dfm & 0x40) == 0x00) { > + m = dfm & 0x3f; > + df = DF_DOUBLE; > + } else if ((dfm & 0x60) == 0x40) { > + m = dfm & 0x1f; > + df = DF_WORD; > + } else if ((dfm & 0x70) == 0x60) { > + m = dfm & 0x0f; > + df = DF_HALF; > + } else if ((dfm & 0x78) == 0x70) { > + m = dfm & 0x7; > + df = DF_BYTE; > + } else { > + generate_exception(ctx, EXCP_RI); > + return; > + } > + > + TCGv_i32 tdf = tcg_const_i32(df); Mixed declarations and code. Otherwise, Reviewed-by: Leon Alrae <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |