qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-img: Omit error_report() after img_open()


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Omit error_report() after img_open()
Date: Mon, 03 Nov 2014 14:58:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Max Reitz <address@hidden> writes:

> img_open() already prints an error if the operation failed, so there
> should not be another error_report() afterwards.
>
> Signed-off-by: Max Reitz <address@hidden>

Especially not when only 4 out of 12 callers do it.

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]