Re: [Qemu-devel] [PATCH v2 RESEND 2/4] block: Add blockdev-backup to transaction

[Eric Blake]

On 11/03/2014 02:47 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  blockdev.c           | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  qapi-schema.json     |  4 ++++
>  qapi/block-core.json |  2 +-
>  3 files changed, 53 insertions(+), 1 deletion(-)
> 

> +++ b/qapi-schema.json
> @@ -1254,11 +1254,15 @@
>  #
>  # A discriminated record of operations that can be performed with
>  # @transaction.
> +#
> +# Since 1.1
> +# blockdev-backup since 2.3
>  ##

It might be nice to document the addition of other branches of this
union (not all of them were in 1.1). But even this is a strict
improvement, so I can live with it.

>  { 'union': 'TransactionAction',
>    'data': {
>         'blockdev-snapshot-sync': 'BlockdevSnapshot',
>         'drive-backup': 'DriveBackup',
> +       'blockdev-backup': 'BlockdevBackup',
>         'abort': 'Abort',
>         'blockdev-snapshot-internal-sync': 'BlockdevSnapshotInternal'
>     } }
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 838b7d6..8c0592f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -698,7 +698,7 @@
>  # If an error occurs during a guest write request, the device's rerror/werror
>  # actions will be used.
>  #
> -# Since: 2.2
> +# Since: 2.3

Did you mean to squash this hunk into 1/4?

>  ##
>  { 'type': 'BlockdevBackup',
>    'data': { 'device': 'str', 'target': 'str',
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature