Re: [Qemu-devel] [PATCH v4 07/47] Create MigrationIncomingState

[Dr. David Alan Gilbert]

* David Gibson (address@hidden) wrote:
> On Fri, Oct 03, 2014 at 06:47:13PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > There are currently lots of pieces of incoming migration state scattered
> > around, and postcopy is adding more, and it seems better to try and keep
> > it together.
> > 
> > allocate MIS in process_incoming_migration_co
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> >  include/migration/migration.h |  9 +++++++++
> >  include/qemu/typedefs.h       |  2 ++
> >  migration.c                   | 28 ++++++++++++++++++++++++++++
> >  savevm.c                      |  2 ++
> >  4 files changed, 41 insertions(+)
> > 
> > diff --git a/include/migration/migration.h b/include/migration/migration.h
> > index 3cb5ba8..8a36255 100644
> > --- a/include/migration/migration.h
> > +++ b/include/migration/migration.h
> > @@ -41,6 +41,15 @@ struct MigrationParams {
> >  
> >  typedef struct MigrationState MigrationState;
> >  
> > +/* State for the incoming migration */
> > +struct MigrationIncomingState {
> > +    QEMUFile *file;
> > +};
> > +
> > +MigrationIncomingState *migration_incoming_get_current(void);
> > +MigrationIncomingState *migration_incoming_state_init(QEMUFile *f);
> 
> Hrm.  I'd prefer to see this called migration_incoming_state_new(),
> since it allocates a new structure, rather than just initializing an
> already allocated one.
> 
> I guess you're trying to match migrate_init() in name, so i guess
> migrate_incoming_init() would work as well.

No, you're right the 1st time, _new is more consistent; fixed.

Dave

> -- 
> David Gibson                  | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au        | minimalist, thank you.  NOT _the_ 
> _other_
>                               | _way_ _around_!
> http://www.ozlabs.org/~dgibson


--
Dr. David Alan Gilbert / address@hidden / Manchester, UK