Re: [Qemu-devel] [PATCH] seccomp: change configure to avoid arm 32 to break

[Peter Maydell]

On 5 November 2014 16:47, Eduardo Otubo <address@hidden> wrote:
> Right now seccomp is breaking the compilation of Qemu on armv7l due
> to libsecomp current lack of support for this arch. This problem is
> already fixed on libseccomp upstream but no release date for that is
> scheduled to far. This patch disables support for seccomp on armv7l
> temporarily until libseccomp does a new release. Then I'll remove the
> hack and update libseccomp dependency on configure script.
>
> Related bug: https://bugs.launchpad.net/qemu/+bug/1363641
>
> Signed-off-by: Eduardo Otubo <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2f17bf3..2ec04b0 100755
> --- a/configure
> +++ b/configure
> @@ -1822,7 +1822,7 @@ fi
>  ##########################################
>  # libseccomp check
>
> -if test "$seccomp" != "no" ; then
> +if test "$seccomp" != "no" && test "$cpu" != "arm" ; then
>      if $pkg_config --atleast-version=2.1.0 libseccomp; then
>          libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
>          QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"

Do we really support all the other CPU architectures, or would
we be better off with a whitelist like:

if test "$cpu" = i386 || test "$cpu" = x86_64; then

?

It seems to me like you'll have exactly the same problem with
any other architecture that happens not to implement a syscall
in your list.

(How are upstream proposing to fix this anyway? I couldn't
figure that out from the mailing list thread.)

thanks
-- PMM