Re: [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

[Stefano Stabellini]

On Tue, 11 Nov 2014, Chen Gang wrote:
> In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> xen_main_loop_prepare() directly, need not use additional variable for
> it.
> 
> Signed-off-by: Chen Gang <address@hidden>

Acked-by: Stefano Stabellini <address@hidden>


>  xen-hvm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen-hvm.c b/xen-hvm.c
> index 21f1cbb..7548794 100644
> --- a/xen-hvm.c
> +++ b/xen-hvm.c
> @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
>  static void xen_hvm_change_state_handler(void *opaque, int running,
>                                           RunState rstate)
>  {
> -    XenIOState *xstate = opaque;
>      if (running) {
> -        xen_main_loop_prepare(xstate);
> +        xen_main_loop_prepare((XenIOState *)opaque);
>      }
>  }
>  
> -- 
> 1.8.5.2 (Apple Git-48)
>