[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/2] virtio-scsi: dataplane: fix allocation f
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 1/2] virtio-scsi: dataplane: fix allocation for 'cmd_vrings' |
|
Date: |
Tue, 11 Nov 2014 12:03:38 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/11/2014 02:17, Ming Lei wrote:
> The size of each element should be sizeof(VirtIOSCSIVring *).
>
> Signed-off-by: Ming Lei <address@hidden>
> ---
> hw/scsi/virtio-scsi-dataplane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c
> index 855439e..df17229 100644
> --- a/hw/scsi/virtio-scsi-dataplane.c
> +++ b/hw/scsi/virtio-scsi-dataplane.c
> @@ -239,7 +239,7 @@ void virtio_scsi_dataplane_start(VirtIOSCSI *s)
> if (!s->event_vring) {
> goto fail_vrings;
> }
> - s->cmd_vrings = g_malloc0(sizeof(VirtIOSCSIVring) * vs->conf.num_queues);
> + s->cmd_vrings = g_new(VirtIOSCSIVring *, vs->conf.num_queues);
> for (i = 0; i < vs->conf.num_queues; i++) {
> s->cmd_vrings[i] =
> virtio_scsi_vring_init(s, vs->cmd_vqs[i],
>
Applied, thanks.
Paolo