[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] vl: Avoid unnecessary 'if' nesting
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] vl: Avoid unnecessary 'if' nesting |
Date: |
Wed, 12 Nov 2014 10:23:28 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Nov 11, 2014 at 04:50:54PM -0200, Eduardo Habkost wrote:
> Just a coding style change, to make other changes easier to review.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> vl.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f4a6e5e..c1bfc9b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1284,13 +1284,11 @@ static void smp_parse(QemuOpts *opts)
> if (cpus == 0) {
> cpus = cores * threads * sockets;
> }
> + } else if (cores == 0) {
> + threads = threads > 0 ? threads : 1;
> + cores = cpus / (sockets * threads);
> } else {
> - if (cores == 0) {
> - threads = threads > 0 ? threads : 1;
> - cores = cpus / (sockets * threads);
> - } else {
> - threads = cpus / (cores * sockets);
> - }
> + threads = cpus / (cores * sockets);
> }
>
> max_cpus = qemu_opt_get_number(opts, "maxcpus", 0);
> --
> 1.9.3
>
Reviewed-by: Andrew Jones <address@hidden>