[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/6] block/raw-posix: Catch fsync() errors
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 6/6] block/raw-posix: Catch fsync() errors |
Date: |
Tue, 18 Nov 2014 12:35:08 +0100 |
From: Max Reitz <address@hidden>
fsync() may fail, and that case should be handled.
Reported-by: László Érsek <address@hidden>
Signed-off-by: Max Reitz <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/raw-posix.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index d106fc4..b1af77e 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1454,7 +1454,12 @@ static int raw_create(const char *filename, QemuOpts
*opts, Error **errp)
left -= result;
}
if (result >= 0) {
- fsync(fd);
+ result = fsync(fd);
+ if (result < 0) {
+ result = -errno;
+ error_setg_errno(errp, -result,
+ "Could not flush new file to disk");
+ }
}
g_free(buf);
break;
--
1.8.3.1
- [Qemu-devel] [PULL 0/6] Block patches for 2.2.0-rc2, Kevin Wolf, 2014/11/18
- [Qemu-devel] [PULL 1/6] raw-posix: Fix comment for raw_co_get_block_status(), Kevin Wolf, 2014/11/18
- [Qemu-devel] [PULL 2/6] raw-posix: SEEK_HOLE suffices, get rid of FIEMAP, Kevin Wolf, 2014/11/18
- [Qemu-devel] [PULL 3/6] raw-posix: The SEEK_HOLE code is flawed, rewrite it, Kevin Wolf, 2014/11/18
- [Qemu-devel] [PULL 5/6] block/raw-posix: Only sync after successful preallocation, Kevin Wolf, 2014/11/18
- [Qemu-devel] [PULL 4/6] block/raw-posix: Fix preallocating write() loop, Kevin Wolf, 2014/11/18
- [Qemu-devel] [PULL 6/6] block/raw-posix: Catch fsync() errors,
Kevin Wolf <=
- Re: [Qemu-devel] [PULL 0/6] Block patches for 2.2.0-rc2, Peter Maydell, 2014/11/18