[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present
From: |
Liviu Ionescu |
Subject: |
Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present |
Date: |
Thu, 20 Nov 2014 14:34:19 +0200 |
On 20 Nov 2014, at 14:29, Peter Maydell <address@hidden> wrote:
>> - if (!kernel_filename && !qtest_enabled()) {
>> + if (!kernel_filename && !qtest_enabled() && !with_gdb) {
>> fprintf(stderr, "Guest image must be specified (using -kernel)\n");
>> exit(1);
>> }
>
> just delete this entire if() statement. This is how we've handled
> similar issues with the ARM A profile boards. (Some of the boards
> still have those checks but that's just because nobody's bothered
> to fix them yet.)
I'm a bit confused. if not running with gdb, what is the expected behaviour if
the image is missing?
Liviu