[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info" |
Date: |
Fri, 21 Nov 2014 10:08:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/21/2014 10:05 AM, Kevin Wolf wrote:
> This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622.
>
> The main reason for reverting this commit before the 2.2 release is that
> it adds a QAPI interface that we don't want to keep: The 'nocow' flag
> doesn't generally make sense for block nodes, but only for the raw-posix
> driver. It should therefore be part of ImageInfoSpecific rather than
> ImageInfo.
>
> The commit contains more problems, but unlike the API stability issue
> they wouldn't justify reverting it.
>
> Conflicts:
> block/qapi.c
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qapi.c | 26 --------------------------
> qapi/block-core.json | 5 +----
> 2 files changed, 1 insertion(+), 30 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature