Re: [Qemu-devel] [PATCH] block: Don't probe for unknown backing file format

[Stefan Hajnoczi]

On Tue, Nov 25, 2014 at 03:19:24PM +0100, Kevin Wolf wrote:
> If a qcow2 image specifies a backing file format that doesn't correspond
> to any format driver that qemu knows, we shouldn't fall back to probing,
> but simply error out.
> 
> Not looking up the backing file driver in bdrv_open_backing_file(), but
> just filling in the "driver" option if it isn't there moves us closer to
> the goal of having everything in QDict options and gets us the error
> handling of bdrv_open(), which correctly refuses unknown drivers.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                    |  7 +++---
>  tests/qemu-iotests/114     | 62 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/114.out | 13 ++++++++++
>  tests/qemu-iotests/group   |  1 +
>  4 files changed, 79 insertions(+), 4 deletions(-)
>  create mode 100755 tests/qemu-iotests/114
>  create mode 100644 tests/qemu-iotests/114.out

Looks good, modulo the test failure that Max noticed.

pgpJqxIiNw2mM.pgp
Description: PGP signature