[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tests: Use "command -v" instead of which(1)
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] tests: Use "command -v" instead of which(1) in shell scripts |
|
Date: |
Wed, 26 Nov 2014 16:21:12 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Nov 19, 2014 at 03:07:12PM +0800, Fam Zheng wrote:
> When which(1) is not installed, we would complain "perl not found"
> because it's the first set_prog_path check. The error message is
> wrong.
>
> Fix it by using "command -v", a native way to query the existence of a
> command.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
> v2: Use "command -v" as suggested by Eric. Also change a few other
> occasions of which(1) in tests/qemu-iotests/common.
> ---
> tests/qemu-iotests/common | 8 ++++----
> tests/qemu-iotests/common.config | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
pgp_tMgXtqgJy.pgp
Description: PGP signature