[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] hmp: Expose read-only option for 'change'
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] hmp: Expose read-only option for 'change' |
|
Date: |
Wed, 26 Nov 2014 09:35:11 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/20/2014 05:44 AM, Max Reitz wrote:
> Expose the new read-only option of qmp_change_blockdev() for the
> 'change' HMP command.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> hmp-commands.hx | 24 +++++++++++++++++++++---
> hmp.c | 17 ++++++++++++++++-
> 2 files changed, 37 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
Even if you go with my suggestion of a new QMP command in 2/3, I'm just
fine with extending the existing HMP command without adding a new name
(although this patch would then have to be modified to call into the new
QMP command as appropriate).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature