[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] coroutine: try harder not to delete corouti
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] coroutine: try harder not to delete coroutines |
Date: |
Sat, 29 Nov 2014 15:28:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 28/11/2014 21:52, Peter Lieven wrote:
>> > + alloc_pool_size += atomic_xchg(&release_pool_size, 0);
> I had alloc_pool_size = in my original Patch.
> It shouldn't make a difference, since alloc_pool_size should be 0
> when we reach this code piece. But if for some reason release_pool_size
> is inaccurate we add this error to alloc_pool_size again and again
> and eventually end up not adding coroutines to the thread local pool below
> altough it might be empty in the worst case.
Oops, this must come from a rebase. Thanks for pointing it out.
Paolo
- Re: [Qemu-devel] [PATCH 5/7] coroutine: rewrite pool to avoid mutex, (continued)
[Qemu-devel] [PATCH 6/7] coroutine: drop qemu_coroutine_adjust_pool_size, Paolo Bonzini, 2014/11/28
[Qemu-devel] [PATCH 7/7] coroutine: try harder not to delete coroutines, Paolo Bonzini, 2014/11/28