[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 13/13] block/raw-posix: Fix ret in raw_open_commo
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 13/13] block/raw-posix: Fix ret in raw_open_common() |
Date: |
Tue, 2 Dec 2014 18:32:53 +0100 |
The return value must be negative on error; there is one place in
raw_open_common() where errp is set, but ret remains 0. Fix it.
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block/raw-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 2e6a919..e51293a 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -446,6 +446,7 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
}
if (fstat(s->fd, &st) < 0) {
+ ret = -errno;
error_setg_errno(errp, errno, "Could not stat file");
goto fail;
}
--
1.9.3
- [Qemu-devel] [PATCH v3 01/13] block: Make essential BlockDriver objects public, (continued)
- [Qemu-devel] [PATCH v3 01/13] block: Make essential BlockDriver objects public, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 02/13] block: Omit bdrv_find_format for essential drivers, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 06/13] qemu-img: Check create_opts before image creation, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 07/13] qemu-img: Check create_opts before image amendment, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 05/13] block: Check create_opts before image creation, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 09/13] iotests: Add test for unsupported image creation, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 08/13] iotests: Only kill NBD server if it runs, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 10/13] qcow2: Prevent numerical overflow, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 12/13] qcow2: Respect bdrv_truncate() error, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 11/13] qcow2: Flushing the caches in qcow2_close may fail, Max Reitz, 2014/12/02
- [Qemu-devel] [PATCH v3 13/13] block/raw-posix: Fix ret in raw_open_common(),
Max Reitz <=
- Re: [Qemu-devel] [PATCH v3 00/13] block: Various Coverity-spotted fixes, Kevin Wolf, 2014/12/03