[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-spe
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info |
|
Date: |
Wed, 03 Dec 2014 08:09:24 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/03/2014 06:37 AM, Max Reitz wrote:
> Add the bit width of every refcount entry to the format-specific
> information.
>
> In contrast to lazy_refcounts and the corrupt flag, this should be
> always emitted, even for compat=0.10 although it does not support any
> refcount width other than 16 bits. This is because if a boolean is
> optional, one normally assumes it to be false when omitted; but if an
> integer is not specified, it is rather difficult to guess its value.
>
> This new field breaks some test outputs, fix them.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 00/26] qcow2: Support refcount orders != 4, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 01/26] qcow2: Add two new fields to BDRVQcowState, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 04/26] qcow2: Only return status from qcow2_get_refcount, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount(), Max Reitz, 2014/12/03