[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after r
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update |
|
Date: |
Wed, 03 Dec 2014 08:13:08 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/03/2014 06:37 AM, Max Reitz wrote:
> qcow2_update_cluster_refcount() does not have any quick access to the
> new refcount value, it has to call qcow2_get_refcount(). Some callers do
> not need that new value at all, others call qcow2_get_refcount()
> themselves anyway (albeit in a different code path, which can however be
> easily changed), therefore there is no advantage in making
> qcow2_update_cluster_refcount() return the new value. Drop it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-refcount.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 00/26] qcow2: Support refcount orders != 4, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 01/26] qcow2: Add two new fields to BDRVQcowState, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 04/26] qcow2: Only return status from qcow2_get_refcount, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount(), Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 06/26] qcow2: Use 64 bits for refcount values, Max Reitz, 2014/12/03