[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/6] vmdk: Remove unnecessary initialization
From: |
Don Koch |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/6] vmdk: Remove unnecessary initialization |
Date: |
Wed, 3 Dec 2014 12:10:59 -0500 |
On Wed, 3 Dec 2014 18:28:40 +0800
Fam Zheng <address@hidden> wrote:
> It will be assigned to the return value of vmdk_read_desc.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Don Koch <address@hidden>
> block/vmdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 045fd7a..ed492bd 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -910,7 +910,7 @@ exit:
> static int vmdk_open(BlockDriverState *bs, QDict *options, int flags,
> Error **errp)
> {
> - char *buf = NULL;
> + char *buf;
> int ret;
> BDRVVmdkState *s = bs->opaque;
> uint32_t magic;
> --
> 1.9.3
>
>
- [Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID, (continued)
- [Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v3 2/6] vmdk: Fix comment to match code of extent lines, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v3 4/6] vmdk: Check descriptor file length when reading it, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v3 5/6] vmdk: Remove unnecessary initialization, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v3 3/6] vmdk: Clean up descriptor file reading, Fam Zheng, 2014/12/03
- [Qemu-devel] [PATCH v3 6/6] vmdk: Set errp on failures in vmdk_open_vmdk4, Fam Zheng, 2014/12/03