Re: [Qemu-devel] [RFC PATCH 1/3] block: add accounting for merged requests

[Eric Blake]

On 12/02/2014 07:33 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  block.c                    |    2 ++
>  block/accounting.c         |    7 +++++++
>  block/qapi.c               |    2 ++
>  hmp.c                      |    6 +++++-
>  include/block/accounting.h |    3 +++
>  qapi/block-core.json       |   10 +++++++++-
>  6 files changed, 28 insertions(+), 2 deletions(-)

Incomplete.  qmp-commands.hx includes a query-blockstats example that
should be updated to show the output of the new non-optional fields.

> +# @wr_merged: Number of write requests that have been merged into another 
> request

Longer than 80 columns; please wrap.

Otherwise looks good to me.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature