[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reall
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reallocation |
Date: |
Wed, 03 Dec 2014 11:00:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/03/2014 06:37 AM, Max Reitz wrote:
> Add a helper function for reallocating a refcount array, independent of
> the refcount order. The newly allocated space is zeroed and the function
> handles failed reallocations gracefully.
>
> The helper function will always align the buffer size to a cluster
> boundary; if storing the refcounts in such an array in big endian byte
> order, this makes it possible to write parts of the array directly as
> refcount blocks into the image file.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-refcount.c | 137
> +++++++++++++++++++++++++++++++------------------
> 1 file changed, 88 insertions(+), 49 deletions(-)
>
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 152ca22..8bb5167 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1130,6 +1130,70 @@ fail:
> /* refcount checking functions */
>
>
> +static size_t refcount_array_byte_size(BDRVQcowState *s, uint64_t entries)
> +{
> + if (s->refcount_order < 3) {
> + /* sub-byte width */
> + int shift = 3 - s->refcount_order;
> + return (entries + (1 << shift) - 1) >> shift;
Bikeshedding: Should this use DIV_ROUND_UP(entries, 1 << shift)?
Either way,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 06/26] qcow2: Use 64 bits for refcount values, (continued)
- [Qemu-devel] [PATCH v4 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes(), Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 07/26] qcow2: Respect error in qcow2_alloc_bytes(), Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reallocation, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 10/26] qcow2: Helper function for refcount modification, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 11/26] qcow2: More helpers for refcount modification, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 12/26] qcow2: Open images with refcount order != 4, Max Reitz, 2014/12/03
- [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/12/03