Re: [Qemu-devel] [PATCH v2] spice: fix memory leak

[Gerd Hoffmann]

On Fr, 2014-12-05 at 16:30 +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
> 
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() returns NULL, and the variable
> cur_item going out of scope leaks the storage it points to.
> 
> The flag is a compatibility thing for older spice-server
> versions. Meanwhile our minimum spice version requirement is
> new enough that we should never ever see this error, and if we
> do something went very seriously wrong. Let's using assert()
> instead of returning NULL to avoid a memory leak.
> 
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Added to spice patch queue.

thanks
  Gerd