[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0 |
Date: |
Tue, 9 Dec 2014 18:24:42 +0100 |
On Tue, 9 Dec 2014 15:46:46 +0200
"Michael S. Tsirkin" <address@hidden> wrote:
> On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote:
> > virtio-ccw should now have everything in place to operate virtio 1.0
> > devices, so let's enable revision 1.
> >
> > Signed-off-by: Cornelia Huck <address@hidden>
>
> Looks like this will allow revision 1 for all devices,
> we only want this for virtio 1 devices.
>
> The following should fix it I think:
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
>
>
> @@ -104,6 +101,12 @@ struct VirtioCcwDevice {
> uint64_t ind_bit;
> };
>
> +/* The maximum virtio revision we support. */
> +static int virtio_ccw_rev_max(VirtioCcwDevice *dev)
Make this "static inline int" and I'm fine with this :)
> +{
> + return dev->host_features & (1ULL << VIRTIO_F_VERSION_1) ? 1 : 0;
> +}
> +
> /* virtual css bus type */
> typedef struct VirtualCssBus {
> BusState parent_obj;
- [Qemu-devel] [PATCH RFC v5 09/19] s390x/css: Add a callback for when subchannel gets disabled, (continued)
- [Qemu-devel] [PATCH RFC v5 09/19] s390x/css: Add a callback for when subchannel gets disabled, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 12/19] virtio: disallow late feature changes for virtio-1, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 11/19] s390x/virtio-ccw: support virtio-1 set_vq format, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 13/19] virtio: allow to fail setting status, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 15/19] virtio-net: no writeable mac for virtio-1, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 16/19] virtio-net: support longer header, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 17/19] virtio-net: enable virtio 1.0, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 18/19] virtio: support revision-specific features, Cornelia Huck, 2014/12/02
- [Qemu-devel] [PATCH RFC v5 19/19] virtio-blk: revision specific feature bits, Cornelia Huck, 2014/12/02