[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets |
Date: |
Thu, 11 Dec 2014 10:08:59 +0100 |
> > +# @websocket: #optional true in case the socket is a websocket (since 2.2).
>
> s/2.2/2.3/
Fixed.
> Is it optional because you omit it when false? Why not just always
> output the bool, so that clients know they are talking to a new-enough
> qemu that knows about websockets (and this is explicitly not one), vs.
> having to guess that the omission of the bool implies that it is not
> rather than being an older qemu.
Makes sense, dropped optional. Also simplifies the code a bit ;)
cheers,
Gerd
- [Qemu-devel] [PATCH v2 06/10] vnc: update docs/multiseat.txt, (continued)
- [Qemu-devel] [PATCH v2 06/10] vnc: update docs/multiseat.txt, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 03/10] vnc: add display id to acl names, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 01/10] vnc: remove vnc_display global, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 07/10] vnc: track & limit connections, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Eric Blake, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/15
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/15