qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets
Date: Thu, 11 Dec 2014 10:08:59 +0100

> > +# @websocket: #optional true in case the socket is a websocket (since 2.2).
> 
> s/2.2/2.3/

Fixed.

> Is it optional because you omit it when false?  Why not just always
> output the bool, so that clients know they are talking to a new-enough
> qemu that knows about websockets (and this is explicitly not one), vs.
> having to guess that the omission of the bool implies that it is not
> rather than being an older qemu.

Makes sense, dropped optional.  Also simplifies the code a bit ;)

cheers,
  Gerd







reply via email to

[Prev in Thread] Current Thread [Next in Thread]