[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/16] block/parallels: introduce ParallelsSnaps
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 14/16] block/parallels: introduce ParallelsSnapshot data structure |
Date: |
Mon, 15 Dec 2014 13:45:44 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben:
> In order to support snapshots of parallels images we should maintain
> snapshots list in BDRVParallelsState. Snapshots actually forms tree.
> Though, in read-only case, we do need to traverse only from current
> snapshot leaf to the snapshot tree root. Thus interesting for us
> snapshots forms old good linked list.
>
> This patch just introduces the structure for this and fills it with
> a signle image as was done before.
s/signle/single/
> True parsing be done in the next patch.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
If I understand correctly, this is what actually describes the backing
file relationship. We should probably use the normal infrastructure for
this.
The challenge here seems to be that the single descriptor XML file
describes the complete chain of backing files. This is different from
the image formats that we support until now.
I think we need some design discussion here first before we even look at
code. Did you consider making the snapshots regular backing files, and
if so, what were the reasons that let you prefer a purely internal
solution?
Kevin
- [Qemu-devel] [PATCH 06/16] iotests: padded parallels image test, (continued)
- [Qemu-devel] [PATCH 06/16] iotests: padded parallels image test, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 03/16] iotests, parallels: quote TEST_IMG in 076 test to be path-safe, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 16/16] iotests: testcase parallels image with snapshots, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 02/16] block/parallels: allow to specify DiskDescriptor.xml instead of image file, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 15/16] block/parallels: support read-only parallels snapshots, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 13/16] block/parallels: read disk size from XML if DiskDescriptor.xml is passed, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 14/16] block/parallels: introduce ParallelsSnapshot data structure, Denis V. Lunev, 2014/12/15
- Re: [Qemu-devel] [PATCH 14/16] block/parallels: introduce ParallelsSnapshot data structure,
Kevin Wolf <=
- [Qemu-devel] [PATCH 11/16] block/parallels: add support for backing files, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 10/16] block/parallels: add get_block_status, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 09/16] block/parallels: read up to cluster end in one go, Denis V. Lunev, 2014/12/15
- [Qemu-devel] [PATCH 12/16] iotests: testcase for backing in parallels format, Denis V. Lunev, 2014/12/15