[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 25/26] qcow2: Point to amend function in check
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v5 25/26] qcow2: Point to amend function in check |
Date: |
Mon, 15 Dec 2014 13:50:56 +0100 |
If a reference count is not representable with the current refcount
order, the image check should point to qemu-img amend for increasing the
refcount order. However, qemu-img amend needs write access to the image
which cannot be provided if the image is marked corrupt; and the image
check will not mark the image consistent unless everything actually is
consistent.
Therefore, if an image is marked corrupt and the image check encounters
a reference count overflow, it cannot be fixed by using qemu-img amend
to increase the refcount order. Instead, one has to use qemu-img convert
to create a completely new copy of the image in this case.
Alternatively, we may want to give the user a way of manually removing
the corrupt flag, maybe through qemu-img amend, but this is not part of
this patch.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2-refcount.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 7c3f8e0..7c9b334 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1370,6 +1370,9 @@ static int inc_refcounts(BlockDriverState *bs,
if (refcount == s->refcount_max) {
fprintf(stderr, "ERROR: overflow cluster offset=0x%" PRIx64
"\n", cluster_offset);
+ fprintf(stderr, "Use qemu-img amend to increase the refcount entry
"
+ "width or qemu-img convert to create a clean copy if the "
+ "image cannot be opened for writing\n");
res->corruptions++;
continue;
}
--
1.9.3
- [Qemu-devel] [PATCH v5 14/26] qcow2: Use symbolic macros in qcow2_amend_options, (continued)
- [Qemu-devel] [PATCH v5 14/26] qcow2: Use symbolic macros in qcow2_amend_options, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 15/26] iotests: Prepare for refcount_bits option, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 16/26] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 17/26] progress: Allow regressing progress, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 18/26] block: Add opaque value to the amend CB, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 19/26] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 20/26] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 21/26] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 24/26] qcow2: Invoke refcount order amendment function, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 22/26] qcow2: Use intermediate helper CB for amend, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 25/26] qcow2: Point to amend function in check,
Max Reitz <=
- [Qemu-devel] [PATCH v5 23/26] qcow2: Add function for refcount order amendment, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 26/26] iotests: Add test for different refcount widths, Max Reitz, 2014/12/15