[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command |
Date: |
Mon, 15 Dec 2014 09:22:32 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/15/2014 02:16 AM, Gerd Hoffmann wrote:
> Hi,
>
>>> > >
>>> > > So better add a 'vencrypt-subauth' enum with this list?
>> >
>> > Yeah probably a good idea
> How does this look like (incremental fixup attached, docs to be
> updated) ?
>
> +++ b/qapi-schema.json
> @@ -785,12 +785,22 @@
> #
> # Since: 2.3
> ##
> +{ 'enum': 'VncPriAuth',
> + 'data': [ 'none', 'vnc', 'ra2', 'ra2ne', 'tight', 'ultra',
> + 'tls', 'vencrypt', 'sasl' ] }
> +{ 'enum': 'VncVencryptSubAuth',
> + 'data': [ 'plain',
> + 'tls-none', 'x509-none',
> + 'tls-vnc', 'x509-vnc',
> + 'tls-plain', 'x509-plain',
> + 'tls-sasl', 'x509-sasl' ] }
Might be worth separate docs for the enums (we've done it elsewhere).
> { 'type': 'VncInfo2',
> - 'data': { 'id' : 'str',
> - 'server' : ['VncBasicInfo'],
> - 'clients' : ['VncClientInfo'],
> - 'auth' : 'str',
> - '*display' : 'str' } }
> + 'data': { 'id' : 'str',
> + 'server' : ['VncBasicInfo'],
> + 'clients' : ['VncClientInfo'],
> + 'auth' : 'VncPriAuth',
> + '*vencrypt' : 'VncVencryptSubAuth',
> + '*display' : 'str' } }
And don't forget docs for 'vencrypt'. But the interface looks fine to me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 07/10] vnc: track & limit connections, (continued)
- [Qemu-devel] [PATCH v2 07/10] vnc: track & limit connections, Gerd Hoffmann, 2014/12/10
- [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Eric Blake, 2014/12/10
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/11
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/15
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Daniel P. Berrange, 2014/12/15
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Gerd Hoffmann, 2014/12/16
- Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command, Eric Blake, 2014/12/16
[Qemu-devel] [PATCH v2 05/10] vnc: allow binding servers to qemu consoles, Gerd Hoffmann, 2014/12/10
[Qemu-devel] [PATCH v2 08/10] vnc: factor out qmp_query_client_list, Gerd Hoffmann, 2014/12/10
[Qemu-devel] [PATCH v2 02/10] vnc: remove unused DisplayState parameter, add id instead., Gerd Hoffmann, 2014/12/10