Re: [Qemu-devel] [PATCH v3 11/15] target-arm: Enable CPU has_el3 prop during VE init

[Peter Maydell]

On 15 December 2014 at 18:51, Greg Bellows <address@hidden> wrote:
> Adds setting of the CPU has_el3 property based on the vexpress machine
> secure state property during initialization.  This enables/disables EL3
> state during start-up.  Changes include adding an additional secure state
> boolean during vexpress CPU initialization.  Also enables the ARM secure boot
> by default.
>
> Signed-off-by: Greg Bellows <address@hidden>

> @@ -724,9 +733,7 @@ static void vexpress_instance_init(Object *obj)
>      vms->secure = true;
>      object_property_add_bool(obj, "secure", vexpress_get_secure,
>                               vexpress_set_secure, NULL);
> -    object_property_set_description(obj, "secure",
> -                             "Set on/off to enable/disable secure state",
> -                             NULL);
> +    object_property_set_description(obj, "secure", SECURE_PROP_DESC, NULL);

You should squash this fix into the earlier patch, rather
than creating the property with the wrong description and
then fixing it.

thanks
-- PMM