Re: [Qemu-devel] [RFC v2 2/4] hw/arm/virt: find_machine_info: handle NULL value

[alvise rigo]

It's just because in patch 1/4 of this series we use
find_machine_info(machine->cpu_model), which could be a NULL pointer.
Indeed this patch can be avoided reworking a bit the calling function code.

Regards,
alvise

On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell <address@hidden> wrote:
> On 21 November 2014 at 18:07, Alvise Rigo <address@hidden> wrote:
>> Signed-off-by: Alvise Rigo <address@hidden>
>> ---
>>  hw/arm/virt.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> index e8d527d..4e7b869 100644
>> --- a/hw/arm/virt.c
>> +++ b/hw/arm/virt.c
>> @@ -151,6 +151,10 @@ static VirtBoardInfo *find_machine_info(const char *cpu)
>>  {
>>      int i;
>>
>> +    if (!cpu) {
>> +        return NULL;
>> +    }
>> +
>>      for (i = 0; i < ARRAY_SIZE(machines); i++) {
>>          if (strcmp(cpu, machines[i].cpu_model) == 0) {
>>              return &machines[i];
>
> What's the motivation for this change? We can never call this
> function with a NULL pointer at the moment...
>
> thanks
> -- PMM