|
From: | Alexander Graf |
Subject: | Re: [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines |
Date: | Tue, 06 Jan 2015 22:46:44 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 06.01.15 14:29, Marcel Apfelbaum wrote: > Some ppc machines create a default usb controller based on a 'machine > condition'. > Until now the logic was: create the usb controller if: > - the usb option was supplied in cli and value is true or > - the usb option was absent and both set_defaults and the machine > condition were true. > > Modified the logic to: > Create the usb controller if: > - the machine condition is true and defaults are enabled or > - the usb option is supplied and true. > > The main for this is to simplify the usb_enabled method. > > Signed-off-by: Marcel Apfelbaum <address@hidden> I think this preserves the logic from a user's perspective quite well. Reviewed-by: Alexander Graf <address@hidden> Alex
[Prev in Thread] | Current Thread | [Next in Thread] |