Re: [Qemu-devel] [PATCH RESEND v2 0/3] vl: smp_parse sanity checks

[Eduardo Habkost]

On Thu, Jan 08, 2015 at 11:48:30AM +0100, Paolo Bonzini wrote:
> 
> 
> On 19/12/2014 03:59, Eduardo Habkost wrote:
> > From the original series sent by Andrew, only patch 1/3 was kept. Patch 2/3
> > from v1 was replaced by a safer fix. Patch 3/3 was removed because it 
> > generates
> > a warning even on the most common use-case ("-smp <n>" without any extra
> > options).
> > 
> > Andrew Jones (1):
> >   vl: fix max_cpus check
> > 
> > Eduardo Habkost (2):
> >   vl: Avoid unnecessary 'if' nesting
> >   vl: Don't silently change topology when all -smp options were set
> > 
> >  vl.c | 22 +++++++++++++---------
> >  1 file changed, 13 insertions(+), 9 deletions(-)
> > 
> 
> Eduardo, I forgot the status of these patches.  Should I just apply
> them?  If so, can you take care of documenting the changes in the 2.3
> release notes?

Yes, please.

I believe 2/3 doesn't need to be in the release notes as it is just a
bug fix which shouldn't break existing setups. 3/3 will make QEMU abort
in (rare?) cases where the command-line was already visibly broken, so I
will document it.

-- 
Eduardo