|
| From: | Pavel Dovgaluk |
| Subject: | Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints |
| Date: | Tue, 13 Jan 2015 12:07:21 +0300 |
> From: Paolo Bonzini [mailto:address@hidden
> On 12/01/2015 13:01, Pavel Dovgalyuk wrote:
> > + default:
> > + case QEMU_CLOCK_VIRTUAL:
> > + if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> > + || !replay_checkpoint(run_all ? 2 : 3)) {
> > + return false;
> > + }
> > + break;
>
> Please document the meaning of the numbers by making an enum.
The numbers have no meaning. They just have to be distinct in different places.
> Why do you have to distinguish run_all?
It seems to be early versions artifact. I'll remove it.
Pavel Dovgalyuk
| [Prev in Thread] | Current Thread | [Next in Thread] |