Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs

[Eduardo Habkost]

On Wed, Jan 07, 2015 at 06:39:13PM +0100, Paolo Bonzini wrote:
[...]
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 5af4300..253009a 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -2621,10 +2621,10 @@ static inline void gen_sto_env_A0(DisasContext *s, 
> int offset)
>  
>  static inline void gen_op_movo(int d_offset, int s_offset)
>  {
> -    tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset);
> -    tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset);
> -    tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + 8);
> -    tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + 8);
> +    tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, 
> XMM_Q(0));
> +    tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + offsetof(XMMReg, 
> XMM_Q(0));
> +    tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, 
> XMM_Q(1));
> +    tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + offsetof(XMMReg, 
> XMM_Q(1));

It looks good (I even sent my Reviewed-by line), but:

target-i386/translate.c:2624:88: error: expected ‘)’ before ‘;’ token
     tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, 
XMM_Q(0));
                                                                                
        ^

-- 
Eduardo