Re: [Qemu-devel] [PATCH 1/2] cpu_ldst.h: Remove unused ldul_ macros

[Paolo Bonzini]

On 13/01/2015 19:32, Peter Maydell wrote:
> The five ldul_ macros are not used anywhere and are marked up with an XXX
> comment. "ldul" is a non-standard prefix for our family of load instructions:
> we don't mark 32-bit accesses for signedness because they return a 32 bit
> quantity. So just delete them.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  include/exec/cpu_ldst.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
> index e5550e7..4700831 100644
> --- a/include/exec/cpu_ldst.h
> +++ b/include/exec/cpu_ldst.h
> @@ -151,15 +151,6 @@
>  
>  #else
>  
> -/* XXX: find something cleaner.
> - * Furthermore, this is false for 64 bits targets
> - */
> -#define ldul_user       ldl_user
> -#define ldul_kernel     ldl_kernel
> -#define ldul_hypv       ldl_hypv
> -#define ldul_executive  ldl_executive
> -#define ldul_supervisor ldl_supervisor
> -
>  /* The memory helpers for tcg-generated code need tcg_target_long etc.  */
>  #include "tcg.h"
>  
> 

Trivial, even.

Reviewed-by: Paolo Bonzini <address@hidden>