[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store ac
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors |
Date: |
Mon, 19 Jan 2015 09:05:15 +0000 |
Peter Maydell <address@hidden> writes:
> Use cpu_*_data instead of the direct *_raw load/store accessors.
I take it this additional level of (macro) redirection is because at
some point there will be a difference between the various cpu accessors?
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target-mips/op_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index d619ba4..ea7d95f 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -74,7 +74,7 @@ void helper_raise_exception(CPUMIPSState *env, uint32_t
> exception)
> static inline type do_##name(CPUMIPSState *env, target_ulong addr, \
> int mem_idx) \
> { \
> - return (type) insn##_raw(addr); \
> + return (type) cpu_##insn##_data(env, addr); \
> }
> #else
> #define HELPER_LD(name, insn, type) \
> @@ -101,7 +101,7 @@ HELPER_LD(ld, ldq, int64_t)
> static inline void do_##name(CPUMIPSState *env, target_ulong addr, \
> type val, int mem_idx) \
> { \
> - insn##_raw(addr, val); \
> + cpu_##insn##_data(env, addr, val); \
> }
> #else
> #define HELPER_ST(name, insn, type) \
--
Alex Bennée
- [Qemu-devel] [PATCH 03/15] target-sparc: Don't use {ld, st}*_raw functions, (continued)
- [Qemu-devel] [PATCH 03/15] target-sparc: Don't use {ld, st}*_raw functions, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 11/15] cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 06/15] linux-user/vm86.c: Use cpu_ldl_data &c rather than plain ldl &c, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 10/15] cpu_ldst.h: Remove unused very short ld*/st* defines, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 01/15] cpu_ldst.h: Remove unused ldul_ macros, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 14/15] cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors, Peter Maydell, 2015/01/15
- Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors,
Alex Bennée <=
- [Qemu-devel] [PATCH 09/15] cpu_ldst.h: Drop unused ld/st*_kernel defines, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 15/15] cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st accessors, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 07/15] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop, Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 05/15] bsd-user/elfload.c: Don't use ldl() or ldq_raw(), Peter Maydell, 2015/01/15
- [Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw(), Peter Maydell, 2015/01/15