[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD |
Date: |
Mon, 19 Jan 2015 10:45:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/19/2015 09:32 AM, Programmingkid wrote:
>
> On Jan 16, 2015, at 3:22 AM, Markus Armbruster wrote:
>
>> Programmingkid <address@hidden> writes:
>>
>>> This patch allows Mac OS X to use a real CDROM disc in QEMU. Testing this
>>> patch will require using QEMU v2.2.0 because the current git version has a
>>> bug in it that prevents /dev/cdrom from being used. "make check" did pass
>>> and my Debian boot disc did work.
>>>
>>> Signed-off-by: John Arbuckle <address@hidden>
>>
>> Subject line is too long, and the body lacks line breaks. Suggest
>> something like:
>>
>> block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD
>
> Unfortunately I can't change the subject line after posting the first version
> of the patch. Others have to know the history of this patch. I will try to
> include the file name in the future.
Yes, you can. It's a bit trickier, in that you'll probably want to
include a mailing list archive link in v8 and explicitly point out that
the subject has changed, as well as a followup to v7 that points to the
list archive of v8 to help people find the changed name. But there is
nothing technically stopping you from renaming a patch to something more
appropriate.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature