Re: [Qemu-devel] [RFC 41/47] pc: acpi-build: create PCI0._CRS dynamically

[Marcel Apfelbaum]

On 01/19/2015 11:55 PM, Michael S. Tsirkin wrote:
> On Mon, Jan 19, 2015 at 01:42:25PM +0100, Paolo Bonzini wrote:
> > On 19/12/2014 03:02, Igor Mammedov wrote:
> > > Replace template patching and runtime
> > > calculation in _CRS() method with static _CRS
> > > defined in SSDT.
> > >
> > > It also drops manual hole patching for reserved
> > > PCI/MEM/CPU hoptlug MMIO resources and utilizes
> > > the fact that MMIO resources are reserved by
> > > respective child /i.e. PHPR, MHPD, PRES/ containers.
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> >
> > This is a good idea.  It's simpler to just do this in the SSDT than to
> > split it between DSDT and SSDT.  The AML's purpose is just to build a
> > static value anyway.
> >
> > Paolo
>
> I think Marcel has patches going in exactly the reverse
> direction with this.
> Marcel?

Actually I added the CRS for the extra root buses in SSDT.
The reason is that it depends on user input.

By the way, I have the code for creating the CRS in code rather that in
the file based on Igor's series.

Thanks,
Marcel

>