[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused |
Date: |
Wed, 21 Jan 2015 09:40:02 +0100 |
On Thu, 8 Jan 2015 12:19:47 +0000
Peter Maydell <address@hidden> wrote:
> The function end_exclusive() isn't used on all targets; mark it as
> such to avoid a clang warning.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index bbd1cfd..0fda51c 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -169,7 +169,7 @@ static inline void start_exclusive(void)
> }
>
> /* Finish an exclusive operation. */
> -static inline void end_exclusive(void)
> +static inline void __attribute__((unused)) end_exclusive(void)
> {
> pending_cpus = 0;
> pthread_cond_broadcast(&exclusive_resume);
IMHO it might be better to add a proper #ifdef guard around that
function. Consider that the calls to end_exclusive() might get removed
completely one day, then you won't get a compiler warning about the
unused function anymore if you used the attribute__((unused)) way.
Thomas
- [Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 3/6] linux-user/arm/nwfpe: Delete unused aCC array, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused, Peter Maydell, 2015/01/08
- Re: [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused,
Thomas Huth <=
- [Qemu-devel] [PATCH 4/6] linux-user/main.c: Call cpu_exec_start/end on all target archs, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 1/6] linux-user/signal.c: Remove current_exec_domain_sig(), Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 6/6] linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for NR_shmat to enable shmat syscall, Peter Maydell, 2015/01/08
- Re: [Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings, Peter Maydell, 2015/01/20