[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused |
|
Date: |
Wed, 21 Jan 2015 10:54:50 +0000 |
On 21 January 2015 at 08:40, Thomas Huth <address@hidden> wrote:
> IMHO it might be better to add a proper #ifdef guard around that
> function. Consider that the calls to end_exclusive() might get removed
> completely one day, then you won't get a compiler warning about the
> unused function anymore if you used the attribute__((unused)) way.
Too painful, and these functions are likely going to go away/change
with the multithreaded-system-emulation support (I hope).
-- PMM
- [Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 3/6] linux-user/arm/nwfpe: Delete unused aCC array, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 4/6] linux-user/main.c: Call cpu_exec_start/end on all target archs, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 1/6] linux-user/signal.c: Remove current_exec_domain_sig(), Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 6/6] linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user, Peter Maydell, 2015/01/08
- [Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for NR_shmat to enable shmat syscall, Peter Maydell, 2015/01/08
- Re: [Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings, Peter Maydell, 2015/01/20