[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation h
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers |
Date: |
Thu, 22 Jan 2015 12:25:47 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Dec 11, 2014 at 02:25:05PM +0100, Cornelia Huck wrote:
> Add virtio_{add,clear}_feature helper functions for manipulating a
> feature bits variable. This has some benefits over open coding:
> - add check that the bit is in a sane range
> - make it obvious at a glance what is going on
> - have a central point to change when we want to extend feature bits
>
> Convert existing code manipulating features to use the new helpers.
>
> Signed-off-by: Cornelia Huck <address@hidden>
Reviewed-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpAQKyKtlQ9m.pgp
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers,
David Gibson <=